[RO359B] platform added #4302
Merged
[RO359B] platform added #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targets/targets.json
Outdated
| "inherits": ["MCU_K24F1M"], | ||
| "detect_code": ["1022"], | ||
| "release_versions": ["2", "5"], | ||
| "extra_labels_add": ["RO359B"] |
There was a problem hiding this comment.
It is not needed, and discouraged, to add yourself to extra_labels.
targets/targets.json
Outdated
| "MCU_K24F1M": { | ||
| "core": "Cortex-M4F", | ||
| "supported_toolchains": ["ARM", "GCC_ARM", "IAR"], | ||
| "extra_labels": ["Freescale", "MCUXpresso_MCUS", "KSDK2_MCUS", "MCU_K24F", "MCU_K24F1M", "KPSDK_MCUS", "KPSDK_CODE", "FLASH_CMSIS_ALGO"], |
There was a problem hiding this comment.
Same comment on this line: you don't need to add yourself to extra_labels, and you should not.
theotherjimmy
changed the title
|
@theotherjimmy fixed pointed things on your review, and ran tests again. |
theotherjimmy
approved these changes
May 12, 2017
|
tools changes and targets.json look fine. |
|
/morph export-build |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 32 All exports and builds passed! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
May 15, 2017
|
Thanks! @toyowata @0xc0170 @theotherjimmy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new platform RO359B, Wi-Fi module that uses K24F. Re-opened, older one is #4281
Now directory stracture are following, and using inherits on target.json
Status
READY
Migrations
NO
Steps to test or reproduce
To test this platform with ci-test-shield, pelase use following patch. PWM test need some wiring and this patch.
https://gist.github.com/ytsuboi/9cc9ae551e4775994a89eb88700105c9
Test results. ( I didn't use above test patch for this test. )
RO359B_test_ARM_20170511.txt
RO359B_test_GCC_ARM_20170511.txt
RO359B_test_IAR_20170511.txt
CC @toyowata @0xc0170 @theotherjimmy